git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] t9001: avoid not portable '\n' with sed

From
Torsten Bögershausen <tboegi@web.de>
Date
Jun 10, 2014, 06:30 UTC
Message-ID
<5396A618.5040306@web.de>
In-Reply-To
<xmqqk38pb95s.fsf@gitster.dls.corp.google.com>
On 06/10/2014 07:55 AM, Junio C Hamano wrote:
Show 5 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes:
>
>> t9001 used a '\n' in a sed expression to split one line into two lines,
>> but the usage of '\n' in the "replacement string" is not portable.
> This looks peculiarly familiar; don't I already have it queued?

Yes, V2 is queued and in pu,and only the commit msg is changed between V2 and V3.

I think that V3 explains the difference between POSIX sed and gnu sed much better, and does reflect all the comments from the list, which otherwise may be lost. And I suspect that not only the sed under Mac OS X does not handle this very '\n' different from gnu sed, or in other words, more platforms may not have a gnu sed and may need the fix.

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 5 in “t9001: avoid not portable '\n' with sed”
  1. t9001: avoid not portable '\n' with sedTorsten Bögershausen, Jun 10, 2014
  2. Eric SunshineJun 10, 2014
  3. Junio C HamanoJun 10, 2014
  4. Torsten BögershausenJun 10, 2014
  5. Junio C HamanoJun 10, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.