Re: [PATCH] contrib: remote-helpers: add move warnings (v2.0)
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- May 13, 2014, 22:47 UTC
- Message-ID
- <5372a0f6650d2_36c411ff3002e@nysa.notmuch>
- In-Reply-To
- <xmqq38gdmhdo.fsf@gitster.dls.corp.google.com>
Junio C Hamano wrote:
Show 8 quoted lines
> Felipe Contreras <felipe.contreras@gmail.com> writes: > > > Sigh, you just don't seem to understand that you are thinking about a > > different issue. I don't think there's any other way I can explain it to > > you. > > Perhaps pointing out which commit(s) to revert might be a good point > to start.
Oh, now you realize it might be nice to avoid this regression I warned you about.
Why don't you continue schooling me about what constitutes a regression? I'm such a slow learner.
I was going to do more than pointing to commits, I was going to provide the fixes with test cases and a detailed explanation. But then you made your decision.
This patch is what I'm suggesting you to do now. And I'll repeat what I already told you.
Good luck with your tree.
-- Felipe Contreras