Re: [PATCH] contrib: remote-helpers: add move warnings (v2.0)

From: Marius Storm-Olsen <mstormo@gmail.com>
Date: May 14, 2014, 02:16 UTC
Message-ID: <5372D205.4040004@gmail.com>
In-Reply-To: <5372a0f6650d2_36c411ff3002e@nysa.notmuch>

On 5/13/2014 5:47 PM, Felipe Contreras wrote:

Show 19 quoted lines

> Junio C Hamano wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
>>
>>> Sigh, you just don't seem to understand that you are thinking
>>> about a different issue. I don't think there's any other way I
>>> can explain it to you.
>>
>> Perhaps pointing out which commit(s) to revert might be a good
>> point to start.
>
> Oh, now you realize it might be nice to avoid this regression I
> warned you about.
>
> Why don't you continue schooling me about what constitutes a
> regression? I'm such a slow learner.
>
> I was going to do more than pointing to commits, I was going to
> provide the fixes with test cases and a detailed explanation. But
> then you made your decision.

I believe the regression in question, mentioned at the bottom of this post
 
http://thread.gmane.org/gmane.comp.version-control.git/248263/focus=248269

     "Since you are not going to do so, I do not feel compelled to fix
      the synchronization crash regression that is present in v2.0.0-rc2
      and I already warned you about."

is referring to this patch
 
http://thread.gmane.org/gmane.comp.version-control.git/247546/focus=247549

but I admit, I'm getting a bit fuzzy around these discussions.

-- 
.marius