git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches

From
tolga ceylan <tolga.ceylan@gmail.com>
Date
Apr 26, 2014, 21:31 UTC
Message-ID
<535C25B5.4050506@gmail.com>
In-Reply-To
<535C2138.3050400@gmail.com>
On 04/26/2014 02:12 PM, tolga ceylan wrote:
Show 11 quoted lines
> Yes, when git-p4 runs git-apply to test the patch, this fails
> due to abbreviated blob object names. I think git-apply requires
> full object names for binary patches.
>
>> This looks like a straightforward change, but can you give a
>> bit more background on why a full index is required?  Do you
>> mean that "git apply" will reject a patch with abbreviated
>> blob object names?
>>
>>         -- Pete
>>
This is the error message git-apply emits in this case:

error: cannot apply binary patch to '<filename>' without full index line error: <filename>: patch does not apply

Cheers, Tolga

Previous: tolga ceylanNext: tolga ceylan
Message 4 of 6 in “git-p4: format-patch to diff-tree change breaks binary patches”
  1. git-p4: format-patch to diff-tree change breaks binary patchesTolga Ceylan, Apr 25, 2014
  2. Pete WyckoffApr 26, 2014
  3. tolga ceylanApr 26, 2014
  4. tolga ceylanApr 26, 2014
  5. tolga ceylanMay 3, 2014
  6. Pete WyckoffMay 5, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.