From: tolga ceylan <tolga.ceylan@gmail.com>
Date: Sat, 26 Apr 2014 21:31:33 GMT
Subject: Re: [PATCH] git-p4: format-patch to diff-tree change breaks binary patches
Message-ID: <535C25B5.4050506@gmail.com>
In-Reply-To: <535C2138.3050400@gmail.com>



On 04/26/2014 02:12 PM, tolga ceylan wrote:
> Yes, when git-p4 runs git-apply to test the patch, this fails
> due to abbreviated blob object names. I think git-apply requires
> full object names for binary patches.
>
>> This looks like a straightforward change, but can you give a
>> bit more background on why a full index is required?  Do you
>> mean that "git apply" will reject a patch with abbreviated
>> blob object names?
>>
>>         -- Pete
>>

This is the error message git-apply emits in this case:

error: cannot apply binary patch to '<filename>' without full index line
error: <filename>: patch does not apply

Cheers,
Tolga