Re: [PATCH] test-lib.sh: use printf instead of echo
Am 15.03.2014 00:57, schrieb Uwe Storbeck:
Show 29 quoted lines
> when variables may contain backslash sequences.
>
> Backslash sequences are interpreted as control characters
> by the echo command of some shells (e.g. dash).
>
> Signed-off-by: Uwe Storbeck <uwe@ibr.ch>
> ---
> t/test-lib.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 1531c24..8209204 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -277,7 +277,7 @@ error "Test script did not set test_description."
>
> if test "$help" = "t"
> then
> - echo "$test_description"
> + printf '%s\n' "$test_description"
> exit 0
> fi
>
> @@ -328,7 +328,7 @@ test_failure_ () {
> test_failure=$(($test_failure + 1))
> say_color error "not ok $test_count - $1"
> shift
> - echo "$@" | sed -e 's/^/# /'
> + printf '%s\n' "$@" | sed -e 's/^/# /'This should be
printf '%s\n' "$*" | sed -e 's/^/# /'
> test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; }
> }
>
> Johannes Sixt <j6t@kdbg.org>