[PATCH v3] test-lib.sh: do not "echo" externally supplied strings
- From
- Uwe Storbeck <uwe@ibr.ch>
- Date
- Mar 18, 2014, 00:14 UTC
- Message-ID
- <20140318001410.GA4813@ibr.ch>
- In-Reply-To
- <20140314235735.GA6959@ibr.ch>
In some places we "echo" a string that is supplied by the calling test script and may contain backslash sequences. The echo command of some shells, most notably "dash", interprets these backslash sequences (POSIX.1 allows this) which may scramble the test output.
Signed-off-by: Uwe Storbeck <uwe@ibr.ch> ---
Commit message rewritten to avoid title continuation in the body. Thanks Junio C Hamano for the hint.
t/test-lib.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh index 1531c24..3c7cb1d 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -277,7 +277,7 @@ error "Test script did not set test_description." if test "$help" = "t" then - echo "$test_description" + printf '%s\n' "$test_description" exit 0 fi @@ -328,7 +328,7 @@ test_failure_ () { test_failure=$(($test_failure + 1)) say_color error "not ok $test_count - $1" shift - echo "$@" | sed -e 's/^/# /' + printf '%s\n' "$*" | sed -e 's/^/# /' test "$immediate" = "" || { GIT_EXIT_OK=t; exit 1; } }
-- 1.9.0