Re: [PATCH v2 0/5] Skip 'cache_tree_update()' when 'prime_cache_tree()' is called immediate after
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Nov 10, 2022, 17:26 UTC
- Message-ID
- <52f94376-bd05-9470-3804-4fcbc5751d18@github.com>
- In-Reply-To
- <pull.1411.v2.git.1668045438.gitgitgadget@gmail.com>
On 11/9/2022 8:57 PM, Victoria Dye via GitGitGadget wrote:
Show 12 quoted lines
> Changes since V1 > ================ > > * Rewrote 'p0090' to more accurately and reliably test 'prime_cache_tree()' > vs. 'cache_tree_update()'. > * Moved iterative cache tree update out of C and into the shell tests (to > avoid potential runtime optimizations) > * Added a "control" test to document how much of the execution time is > startup overhead > * Added tests demonstrating performance in partially-invalid cache trees. > * Fixed the use of 'prime_cache_tree()' in 'test-tool cache-tree', changing > it from using the tree at HEAD to the current cache tree.
I did a re-read of this series and it looks good to me.
Thanks for doing this investigation! -Stolee