git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups

From
Felipe Contreras <felipe.contreras@gmail.com>
Date
Dec 7, 2013, 09:37 UTC
Message-ID
<52a2ec51d8a67_29836d5e984f@nysa.notmuch>
In-Reply-To
<1386066764-49711-1-git-send-email-john@szakmeister.net>
John Szakmeister wrote:
Show 22 quoted lines
> Signed-off-by: John Szakmeister <john@szakmeister.net>
> ---
> The gnome-keyring credential backend had a number of coding style
> violations.  I believe this fixes all of them.
> 
>  .../gnome-keyring/git-credential-gnome-keyring.c   | 55 ++++++++++------------
>  1 file changed, 25 insertions(+), 30 deletions(-)
> 
> diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> index 635c96b..1613404 100644
> --- a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> +++ b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c
> @@ -95,9 +95,9 @@ static const char* gnome_keyring_result_to_message(GnomeKeyringResult result)
>  
>  static void gnome_keyring_done_cb(GnomeKeyringResult result, gpointer user_data)
>  {
> -	gpointer *data = (gpointer*) user_data;
> -	int *done = (int*) data[0];
> -	GnomeKeyringResult *r = (GnomeKeyringResult*) data[1];
> +	gpointer *data = (gpointer *) user_data;
> +	int *done = (int *) data[0];
> +	GnomeKeyringResult *r = (GnomeKeyringResult *) data[1];
No need for these castings, a gpointer is void *, so there's no need to cast them.
-- 
Felipe Contreras
Previous: Junio C HamanoNext: John Szakmeister
Message 3 of 8 in “contrib/git-credential-gnome-keyring.c: small stylistic cleanups”
  1. contrib/git-credential-gnome-keyring.c: small stylistic cleanupsJohn Szakmeister, Dec 3, 2013
  2. Junio C HamanoDec 5, 2013
  3. Felipe ContrerasDec 7, 2013
  4. contrib/git-credential-gnome-keyring.c: small stylistic cleanupsJohn Szakmeister, Dec 7, 2013
  5. Junio C HamanoDec 9, 2013
  6. John SzakmeisterDec 10, 2013
  7. Junio C HamanoDec 12, 2013
  8. Junio C HamanoDec 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.