From: Felipe Contreras Date: Sat, 07 Dec 2013 09:37:21 GMT Subject: RE: [PATCH] contrib/git-credential-gnome-keyring.c: small stylistic cleanups Message-ID: <52a2ec51d8a67_29836d5e984f@nysa.notmuch> In-Reply-To: <1386066764-49711-1-git-send-email-john@szakmeister.net> John Szakmeister wrote: > Signed-off-by: John Szakmeister > --- > The gnome-keyring credential backend had a number of coding style > violations. I believe this fixes all of them. > > .../gnome-keyring/git-credential-gnome-keyring.c | 55 ++++++++++------------ > 1 file changed, 25 insertions(+), 30 deletions(-) > > diff --git a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c > index 635c96b..1613404 100644 > --- a/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c > +++ b/contrib/credential/gnome-keyring/git-credential-gnome-keyring.c > @@ -95,9 +95,9 @@ static const char* gnome_keyring_result_to_message(GnomeKeyringResult result) > > static void gnome_keyring_done_cb(GnomeKeyringResult result, gpointer user_data) > { > - gpointer *data = (gpointer*) user_data; > - int *done = (int*) data[0]; > - GnomeKeyringResult *r = (GnomeKeyringResult*) data[1]; > + gpointer *data = (gpointer *) user_data; > + int *done = (int *) data[0]; > + GnomeKeyringResult *r = (GnomeKeyringResult *) data[1]; No need for these castings, a gpointer is void *, so there's no need to cast them. -- Felipe Contreras