Re: [PATCH 2/5] safe_create_leading_directories(): reduce scope of local variable

From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Jan 1, 2014, 12:39 UTC
Message-ID: <52C40C9B.2040001@alum.mit.edu>
In-Reply-To: <20131226215559.GX20443@google.com>

On 12/26/2013 10:55 PM, Jonathan Nieder wrote:

Show 23 quoted lines

> Michael Haggerty wrote:
> 
>> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
>> ---
>>  sha1_file.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/sha1_file.c b/sha1_file.c
>> index c9245a6..cc9957e 100644
>> --- a/sha1_file.c
>> +++ b/sha1_file.c
>> @@ -108,9 +108,10 @@ int mkdir_in_gitdir(const char *path)
>>  int safe_create_leading_directories(char *path)
>>  {
>>  	char *pos = path + offset_1st_component(path);
>> -	struct stat st;
>>  
>>  	while (pos) {
>> +		struct stat st;
> 
> Is this to make it easier to reason about whether 'st' has been
> properly initialized at any given moment, or is there a more subtle
> reason?

No, just the boring reason, the one that makes me reduce the scope of variables whenever possible. I'll buff up the log message.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/