Re: [PATCH 2/5] safe_create_leading_directories(): reduce scope of local variable

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Dec 26, 2013, 21:55 UTC
Message-ID: <20131226215559.GX20443@google.com>
In-Reply-To: <1387696451-32224-3-git-send-email-mhagger@alum.mit.edu>

Michael Haggerty wrote:

Show 17 quoted lines

> Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
> ---
>  sha1_file.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sha1_file.c b/sha1_file.c
> index c9245a6..cc9957e 100644
> --- a/sha1_file.c
> +++ b/sha1_file.c
> @@ -108,9 +108,10 @@ int mkdir_in_gitdir(const char *path)
>  int safe_create_leading_directories(char *path)
>  {
>  	char *pos = path + offset_1st_component(path);
> -	struct stat st;
>  
>  	while (pos) {
> +		struct stat st;

Is this to make it easier to reason about whether 'st' has been properly initialized at any given moment, or is there a more subtle reason?

Curious, Jonathan