git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git-submodule.sh respects submodule.$name.update in .git/config but not .gitmodules

From
Jens Lehmann <jens.lehmann@web.de>
Date
Dec 12, 2013, 18:57 UTC
Message-ID
<52AA072F.2000105@web.de>
In-Reply-To
<7vtxeeuaw7.fsf@alter.siamese.dyndns.org>
Am 12.12.2013 02:16, schrieb Junio C Hamano:
Show 20 quoted lines
> "W. Trevor King" <wking@tremily.us> writes:
> 
>> For
>> safety, maybe the default `init` should copy *everything* into
>> .git/config, after which users can remove stuff they'd like to
>> delegate to .gitmodules.
> 
> Copying everything into config is "be unsafe and inconvenient by
> default for everybody", isn't it?  Folks who want safety are forced
> to inspect the resulting entries in their config file (which is more
> inconvenent if you compare with the design where nothing is copied
> and nothing dynamically defaults to what then-current .gitmodules
> happens to contain).  Folks who trust those who update .gitmodules
> for them are forced to update their config every time upstream
> decides to use different settings in .gitmodules, because they have
> stale values in their config that mask what are in .gitmodules.
> 
> I think the solution we want is to copy only minimum to the config
> (and that "minimum" may turn out to be "nothing"), and to default
> keys that are only absolutely safe to .gitmodules file.
I agree and will prepare a patch for that.

What about teaching "git submodule sync" the "--url", "--update", "--fetch", "--ignore", "--branch" and "--all" options to allow the user to copy the current settings he wants from .gitmodules to .git/config (but only safe values of course)? Trevor, would you be ok to issue another command to copy everything to .git/config?

Previous: Junio C HamanoNext: W. Trevor King
Message 7 of 10 in “git-submodule.sh respects submodule.$name.update in .git/config but not .gitmodules”
  1. Charlie DysonDec 6, 2013
  2. Heiko VoigtDec 9, 2013
  3. Junio C HamanoDec 9, 2013
  4. Jens LehmannDec 11, 2013
  5. W. Trevor KingDec 11, 2013
  6. Junio C HamanoDec 12, 2013
  7. Jens LehmannDec 12, 2013
  8. W. Trevor KingDec 12, 2013
  9. Jonathan NiederDec 12, 2013
  10. Junio C HamanoDec 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.