git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: git-submodule.sh respects submodule.$name.update in .git/config but not .gitmodules

From
W. Trevor King <wking@tremily.us>
Date
Dec 11, 2013, 22:44 UTC
Message-ID
<20131211224424.GB25409@odin.tremily.us>
In-Reply-To
<52A8E689.80701@web.de>
On Wed, Dec 11, 2013 at 11:26:17PM +0100, Jens Lehmann wrote:
Show 14 quoted lines
> Am 10.12.2013 00:40, schrieb Junio C Hamano:
> > Heiko Voigt <hvoigt@hvoigt.net> writes:
> >> This notion has changed in a way that only the url (by that the
> >> name) should be copied on init. The default for everything else
> >> should come from .gitmodules or gits own default.
> > 
> > I think you need to be a bit careful here.  I do not think
> > everything should blindly default to .gitmodules (otherwise there
> > are obvious security implications as well as usability ones).
> 
> I believe everything except the URL should default to .gitmodules,
> for the same reasons we already do that for fetch and ignore [1].
> But it should not do so blindly and take precautions that this only
> happens for safe values.

I think the "safety of .git/config vs. convenience of .gitmodules" balance is going to break down differently for different folks. That's why I proposed get_submodule_config() [1] and submodule.<name>.active as an activation marker [2,3]. Then users can move as much or as little of the submodule config from .gitmodules into .git/config to strike the balance they feel is appropriate. For safety, maybe the default `init` should copy *everything* into .git/config, after which users can remove stuff they'd like to delegate to .gitmodules.

Cheers, Trevor

[1]: http://article.gmane.org/gmane.comp.version-control.git/210930 [2]: http://article.gmane.org/gmane.comp.version-control.git/211014 [3]: http://article.gmane.org/gmane.comp.version-control.git/211042

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
Previous: Jens LehmannNext: Junio C Hamano
Message 5 of 10 in “git-submodule.sh respects submodule.$name.update in .git/config but not .gitmodules”
  1. Charlie DysonDec 6, 2013
  2. Heiko VoigtDec 9, 2013
  3. Junio C HamanoDec 9, 2013
  4. Jens LehmannDec 11, 2013
  5. W. Trevor KingDec 11, 2013
  6. Junio C HamanoDec 12, 2013
  7. Jens LehmannDec 12, 2013
  8. W. Trevor KingDec 12, 2013
  9. Jonathan NiederDec 12, 2013
  10. Junio C HamanoDec 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.