git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Oct 2013, #07; Mon, 28)

From
Torsten Bögershausen <tboegi@web.de>
Date
Oct 30, 2013, 16:51 UTC
Message-ID
<5271392E.8020003@web.de>
In-Reply-To
<xmqqr4b5dwke.fsf@gitster.dls.corp.google.com>
On 2013-10-28 20.28, Junio C Hamano wrote:
> * jk/pack-bitmap (2013-10-28) 20 commits

There is a name clash under cygwin 1.7 (1.5 is OK) The following "first aid hot fix" works for me: /Torsten

$ git diff
diff --git a/compat/bswap.h b/compat/bswap.h
index ea1a9ed..8dc39be 100644
--- a/compat/bswap.h
+++ b/compat/bswap.h
@@ -64,7 +64,7 @@ static inline uint32_t git_bswap32(uint32_t x)
 #      if defined(__GNUC__) && defined(__GLIBC__)
 #              include <byteswap.h>
 #      else /* GNUC & GLIBC */
-static inline uint64_t bswap_64(uint64_t val)
+static inline uint64_t git_bswap_64(uint64_t val)
 {
        return ((val & (uint64_t)0x00000000000000ffULL) << 56)
                | ((val & (uint64_t)0x000000000000ff00ULL) << 40)
@@ -76,8 +76,8 @@ static inline uint64_t bswap_64(uint64_t val)
                | ((val & (uint64_t)0xff00000000000000ULL) >> 56);
 }
 #      endif /* GNUC & GLIBC */
-#      define ntohll(n) bswap_64(n)
-#      define htonll(n) bswap_64(n)
+#      define ntohll(n) git_bswap_64(n)
+#      define htonll(n) git_bswap_64(n)
 #else /* __BYTE_ORDER */
 #      error "Can't define htonll or ntohll!"
 #endif
Previous: Thomas RastNext: Vicent Martí
Message 3 of 15 in “What's cooking in git.git (Oct 2013, #07; Mon, 28)”
  1. Junio C HamanoOct 28, 2013
  2. Thomas RastOct 28, 2013
  3. Torsten BögershausenOct 30, 2013
  4. Vicent MartíOct 30, 2013
  5. Torsten BögershausenOct 30, 2013
  6. Torsten BögershausenOct 30, 2013
  7. Ramsay JonesOct 30, 2013
  8. Ramsay JonesOct 30, 2013
  9. Torsten BögershausenOct 30, 2013
  10. Ramsay JonesOct 30, 2013
  11. Torsten BögershausenOct 31, 2013
  12. Ramsay JonesNov 5, 2013
  13. Torsten BögershausenNov 6, 2013
  14. Jakub NarębskiNov 12, 2013
  15. Andreas EricssonNov 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.