Re: [PATCH 1/9] transport-helper: add 'force' to 'export' helpers

From: Richard Hansen <rhansen@bbn.com>
Date: Sep 23, 2013, 02:41 UTC
Message-ID: <523FAA59.6040200@bbn.com>
In-Reply-To: <1377789808-2213-2-git-send-email-felipe.contreras@gmail.com>

On 2013-08-29 11:23, Felipe Contreras wrote:

Show 18 quoted lines

> Otherwise they cannot know when to force the push or not (other than
> hacks).
> 
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  transport-helper.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/transport-helper.c b/transport-helper.c
> index 63cabc3..62051a6 100644
> --- a/transport-helper.c
> +++ b/transport-helper.c
> @@ -814,6 +814,9 @@ static int push_refs_with_export(struct transport *transport,
>  			die("helper %s does not support dry-run", data->name);
>  	}
>  
> +	if (flags & TRANSPORT_PUSH_FORCE)
> +		set_helper_option(transport, "force", "true");

Should the return value of set_helper_option() be checked?

Also, should there be a #define TRANS_OPT_FORCE "force" with TRANS_OPT_FORCE added to boolean_options[]?

Thanks, Richard