Re: [PATCH 2/2] stage: add edit command

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Aug 29, 2013, 18:42 UTC
Message-ID: <521f960477ebf_16921225e74769a3@nysa.mail>
In-Reply-To: <vpqk3j4s5ut.fsf@anie.imag.fr>

Matthieu Moy wrote:

Show 10 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> > +'edit'::
> > +
> > +Manually edit the staging area (as a diff).
> > +
> 
> That sounds interesting. It reminds me "git add --edit", but they are
> different ('stage edit' edits the patch with HEAD, 'add --edit' edits
> the patch with the worktree).

That's not the only difference; 'add --edit' is incremental.

> Can we find a consistent user-interface where "git add --edit" and "git
> stage edit" have a closer syntax? Maybe "git stage edit --work" as a
> synonym for "git add --edit"?

Well, the action is adding changes to the staging area. To me, I'm not editing the stage, I'm editing the change I'm adding to the stage, so 'git stage --edit' is perfectly fine.

-- 
Felipe Contreras