Re: [PATCH 00/12] tree-wide: chip away at USE_THE_INDEX_COMPATIBILITY_MACROS

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Nov 18, 2022, 12:13 UTC
Message-ID: <51e91e8f-f11c-be8c-a23d-566eb3fbb387@dunelm.org.uk>
In-Reply-To: <cover-00.12-00000000000-20221118T112205Z-avarab@gmail.com>

Hi Ævar

On 18/11/2022 11:30, Ævar Arnfjörð Bjarmason wrote:

> As 3/12 here notes we've been undergoing a sloooow migration away from
> functions that provide "the_index" for you since 2007, with the last
> major move away from some of them being in 2019.

The commit cited in 3/12 actually introduced most of these macros. What it did was remove the dependency on `the_index` from cache.c. Maybe I'm missing some context but I struggling to see the benefit in removing the macros with out removing the dependency on `the_index`. Doing that would require much more manual work as it cannot be automated with coccinelle but it would provide a tangible benefit which I don't see here.

Best Wishes

Phillip