Re: What's cooking in git.git (May 2013, #08; Tue, 28)
- From
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
- Date
- May 29, 2013, 23:44 UTC
- Message-ID
- <51A692F4.5080805@ramsay1.demon.co.uk>
- In-Reply-To
- <7vli6yydmv.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
Show 5 quoted lines
> > * rj/mingw-compat-st-mode-bits (2013-05-28) 1 commit > - path: Fix a sparse warning > > Will merge to 'next'.
Hmm, this breaks the build on cygwin. :(
Now, I always test my patches on Linux, cygwin and MinGW before sending, ... except that I obviously didn't test on cygwin this time - it doesn't even compile. *ahem*
The extern declaration for get_st_mode_bits() must come *before* including compat/cygwin.h; otherwise it will get mangled by the macro in that header file.
Sorry for breaking the build.
A v3 patch is on it's way. (I'm liking the v1 patch more now ;-)
ATB, Ramsay Jones