Re: [PATCH v2 4/7] add tests for rebasing root
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- May 29, 2013, 07:31 UTC
- Message-ID
- <51A5AECF.6070702@viscovery.net>
- In-Reply-To
- <1369809572-24431-5-git-send-email-martinvonz@gmail.com>
Am 5/29/2013 8:39, schrieb Martin von Zweigbergk:
Show 8 quoted lines
> +test_run_rebase () {
> + result=$1
> + shift
> + test_expect_$result "rebase $* --onto --root with merge-base does not go to root" "
> + reset_rebase &&
> + git rebase $* --onto m --root g &&
> + test_cmp_rev m HEAD~2 &&
> + test_linear_range 'c g' m..Here you check the outcome. There is no explicit check whether the rebase attempted to replay a and b. But that check is implicit: If a or b were attempted to replay, the rebase would have been interrupted with "no new changes". Right?
Show 7 quoted lines
> + " > +} > + > +test_run_rebase success '' > +test_run_rebase success -m > +test_run_rebase success -i > +test_run_rebase failure -p
Just curious: Does the last one fail because the result is not correct or because it does go to the root?
-- Hannes