git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 1/6] send-email: make annotate configurable

From
Jakub Narębski <jnareb@gmail.com>
Date
Apr 9, 2013, 13:51 UTC
Message-ID
<51641CE8.4000704@gmail.com>
In-Reply-To
<1365356784-24872-2-git-send-email-felipe.contreras@gmail.com>
W dniu 07.04.2013 19:46, Felipe Contreras pisze:
Show 8 quoted lines
> @@ -212,7 +212,8 @@ my %config_bool_settings = (
>      "signedoffbycc" => [\$signed_off_by_cc, undef],
>      "signedoffcc" => [\$signed_off_by_cc, undef],      # Deprecated
>      "validate" => [\$validate, 1],
> -    "multiedit" => [\$multiedit, undef]
> +    "multiedit" => [\$multiedit, undef],
> +    "annotate" => [\$annotate, undef]
>  );

Why not leave hanging "," to make it easier on future changes, i.e.:

  -    "multiedit" => [\$multiedit, undef]
  +    "multiedit" => [\$multiedit, undef],
  +    "annotate" => [\$annotate, undef],
-- 
Jakub Narębski
Previous: Felipe ContrerasNext: Felipe Contreras
Message 3 of 13 in “send-email: configuration improvements”
  1. 0/6 send-email: configuration improvementsFelipe Contreras, Apr 7, 2013
  2. 1/6 send-email: make annotate configurableFelipe Contreras, Apr 7, 2013
  3. Jakub NarębskiApr 9, 2013
  4. 2/6 format-patch: improve head calculation for cover-letterFelipe Contreras, Apr 7, 2013
  5. 3/6 format-patch: refactor branch name calculationFelipe Contreras, Apr 7, 2013
  6. 4/6 log: update to OPT_BOOLFelipe Contreras, Apr 7, 2013
  7. 5/6 format-patch: add format.cover-letter configurationFelipe Contreras, Apr 7, 2013
  8. Simon RuderichApr 7, 2013
  9. Jonathan NiederApr 7, 2013
  10. t/README: --immediate skips cleanup commands for failed testsSimon Ruderich, Apr 9, 2013
  11. Junio C HamanoApr 9, 2013
  12. t/README: --immediate skips cleanup commands for failed testsSimon Ruderich, Apr 9, 2013
  13. 6/6 format-patch: trivial cleanupsFelipe Contreras, Apr 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.