git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 5/6] format-patch: add format.cover-letter configuration

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Apr 7, 2013, 22:32 UTC
Message-ID
<20130407223200.GF19857@elie.Belkin>
In-Reply-To
<20130407193415.GB13708@ruderich.org>
Hi,
Simon Ruderich wrote:
> On Sun, Apr 07, 2013 at 12:46:23PM -0500, Felipe Contreras wrote:
>> +test_expect_success 'cover letter auto' '
>> +	mkdir -p tmp &&
>> +	test_when_finished "rm -rf tmp;
[...]
> I'm not sure if it's better to use test_when_finished with rm or
> just && rm -rf tmp at the end of the test in case someone wants
> to look at the output.

test_when_finished is better here, since it means later tests can run and provide useful information about how bad a regression is. Cleanup commands requested using test_when_finished are not run when a test being run with --immediate fails, so you can still inspect output after a failed test.

Thanks and hope that helps, Jonathan

Previous: Simon RuderichNext: Simon Ruderich
Message 9 of 13 in “send-email: configuration improvements”
  1. 0/6 send-email: configuration improvementsFelipe Contreras, Apr 7, 2013
  2. 1/6 send-email: make annotate configurableFelipe Contreras, Apr 7, 2013
  3. Jakub NarębskiApr 9, 2013
  4. 2/6 format-patch: improve head calculation for cover-letterFelipe Contreras, Apr 7, 2013
  5. 3/6 format-patch: refactor branch name calculationFelipe Contreras, Apr 7, 2013
  6. 4/6 log: update to OPT_BOOLFelipe Contreras, Apr 7, 2013
  7. 5/6 format-patch: add format.cover-letter configurationFelipe Contreras, Apr 7, 2013
  8. Simon RuderichApr 7, 2013
  9. Jonathan NiederApr 7, 2013
  10. t/README: --immediate skips cleanup commands for failed testsSimon Ruderich, Apr 9, 2013
  11. Junio C HamanoApr 9, 2013
  12. t/README: --immediate skips cleanup commands for failed testsSimon Ruderich, Apr 9, 2013
  13. 6/6 format-patch: trivial cleanupsFelipe Contreras, Apr 7, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.