git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] fast-export: Add a --tag-of-filtered-object option for newly dangling tags

From
Elijah Newren <newren@gmail.com>
Date
Jun 26, 2009, 04:45 UTC
Message-ID
<51419b2c0906252145pe174d1diddee9ed81413af74@mail.gmail.com>
In-Reply-To
<7vd48wazhu.fsf@alter.siamese.dyndns.org>
Hi,

Thanks for the detailed feedback and suggestions. I'll send a new patch series shortly, which I believe addresses all your suggestions and requests (and opens up a new issue), but there is one item in particular I wanted to respond to...

On Mon, Jun 22, 2009 at 12:34 PM, Junio C Hamano<gitster@pobox.com> wrote:
Show 5 quoted lines
> Also, are you absolutely sure that your revs is always limited at this
> point?  Otherwise, the parents of this commit are queued in rev->list,
> expecting somebody else to later pick them up and further process, but
> there is nobody who does that in your codepath as far as I can see.  What
> will happen to these parent commits?

revs was not limited, but should have been. Inside setup_revisions, revs->limited is set if revs->topo_order is, but unfortunately we weren't setting revs->topo_order until after the call to setup_revisions. So, as you suggest, my code caused the parents of the rewritten commit to needlessly get queued up and left around, with no one to process them. Oops.

Elijah
Previous: Junio C HamanoNext: newren@gmail.com
Message 9 of 11 in “A few fast export fixups -- round 2”
  1. newren@gmail.comJun 22, 2009
  2. fast-export: Omit tags that tag treesnewren@gmail.com, Jun 22, 2009
  3. Junio C HamanoJun 22, 2009
  4. fast-export: Make sure we show actual ref names instead of "(null)"newren@gmail.com, Jun 22, 2009
  5. Junio C HamanoJun 22, 2009
  6. fast-export: Do parent rewriting to avoid dropping relevant commitsnewren@gmail.com, Jun 22, 2009
  7. fast-export: Add a --tag-of-filtered-object option for newly dangling tagsnewren@gmail.com, Jun 22, 2009
  8. Junio C HamanoJun 22, 2009
  9. Elijah NewrenJun 26, 2009
  10. Add new fast-export testcasesnewren@gmail.com, Jun 22, 2009
  11. fast-export: Document the fact that git-rev-list arguments are acceptednewren@gmail.com, Jun 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.