git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2] fast-export: Make sure we show actual ref names instead of "(null)"

From
newren@gmail.com <newren@gmail.com>
Date
Jun 22, 2009, 13:06 UTC
Message-ID
<1245676001-14734-3-git-send-email-newren@gmail.com>
In-Reply-To
<1245676001-14734-1-git-send-email-newren@gmail.com>
From: Elijah Newren <newren@gmail.com>
Under some cases (e.g. 'git fast-export --parents master -- COPYING' run
in git.git), the output included the lines
  reset (null)
  commit (null)
instead of
  reset refs/heads/master
  commit refs/heads/master
This simple change fixes that.
Signed-off-by: Elijah Newren <newren@gmail.com>
---
(No change to this patch since the first series.)
As noted above, run 'git fast-export --parents master -- COPYING' in
git.git to see this bug triggered.
 builtin-fast-export.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin-fast-export.c b/builtin-fast-export.c
index 891e2d4..9aa409b 100644
--- a/builtin-fast-export.c
+++ b/builtin-fast-export.c
@@ -531,6 +531,7 @@ int cmd_fast_export(int argc, const char **argv, const char *prefix)
 	get_tags_and_duplicates(&revs.pending, &extra_refs);
 
 	revs.topo_order = 1;
+	revs.show_source = 1;
 	if (prepare_revision_walk(&revs))
 		die("revision walk setup failed");
 	revs.diffopt.format_callback = show_filemodify;
-- 
1.6.0.6
Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 11 in “A few fast export fixups -- round 2”
  1. newren@gmail.comJun 22, 2009
  2. fast-export: Omit tags that tag treesnewren@gmail.com, Jun 22, 2009
  3. Junio C HamanoJun 22, 2009
  4. fast-export: Make sure we show actual ref names instead of "(null)"newren@gmail.com, Jun 22, 2009
  5. Junio C HamanoJun 22, 2009
  6. fast-export: Do parent rewriting to avoid dropping relevant commitsnewren@gmail.com, Jun 22, 2009
  7. fast-export: Add a --tag-of-filtered-object option for newly dangling tagsnewren@gmail.com, Jun 22, 2009
  8. Junio C HamanoJun 22, 2009
  9. Elijah NewrenJun 26, 2009
  10. Add new fast-export testcasesnewren@gmail.com, Jun 22, 2009
  11. fast-export: Document the fact that git-rev-list arguments are acceptednewren@gmail.com, Jun 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.