Re: [PATCH] Bugfix: undefined htmldir in config.mak.autogen

From: Stefano Lattarini <stefano.lattarini@gmail.com>
Date: Feb 20, 2013, 12:30 UTC
Message-ID: <5124C1FC.6050004@gmail.com>
In-Reply-To: <CANYiYbHpEd8kgv2nPvJgDvNLhzHbYJ8uN2gLNWWwCWvrVExpBA@mail.gmail.com>

On 02/20/2013 11:42 AM, Jiang Xin wrote:

Show 32 quoted lines

>  2013/2/20 Stefano Lattarini <stefano.lattarini@gmail.com>:
>> On 02/20/2013 02:39 AM, Jiang Xin wrote:
>>>
>>> [SNIP]
>>>
>>> I am not familiar with autoconf. After clone autoconf and check,
>>> I cannot find a neat way to change "htmldir" default location to
>>> use ${datarootdir} (just like mandir).
>>>
>> This one-line change should be enough to do what you want:
>>
>>   diff --git a/configure.ac b/configure.ac
>>   index 1991258..2bfbec9 100644
>>   --- a/configure.ac
>>   +++ b/configure.ac
>>   @@ -149,6 +149,8 @@ AC_CONFIG_SRCDIR([git.c])
>>    config_file=config.mak.autogen
>>    config_in=config.mak.in
>>
>>   +AC_SUBST([htmldir], ['${datarootdir}'])
>>   +
>>    GIT_CONF_SUBST([AUTOCONFIGURED], [YesPlease])
>>
> 
> If changed like that, set:
> 
>      AC_SUBST([htmldir], ['${datarootdir}/doc/git-doc'])
> 
> In the generated "configure" file, this instruction will be inserted
> after the option_parse block (not before), and will override what
> the user provided by running "./configure --htmldir=DOCDIR".
>

Yikes, you're right. Scratch my suggestion then; the issue should probably be brought up on the autoconf mailing list. Albeit I think it is by design that autoconf doesn't let a package to override the defaults for installation directory: this way, the end users can expect consistent, well-documented defaults for all autoconf-based packages.

> BTW, add "docdir = @docdir@" to "config.mak.in", also let
> "./configure --docdir=DIR" works properly.
>

Thanks, and sorry for the noise,
  Stefano