git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] Bugfix: undefined htmldir in config.mak.autogen

From
Jiang Xin <worldhello.net@gmail.com>
Date
Feb 19, 2013, 11:23 UTC
Message-ID
<1be0a520b99fbfecd7255c1d26753015612856b3.1361272864.git.worldhello.net@gmail.com>

Html documents will be installed to root dir (/) no matter what prefix is set, if run these commands before `make` and `make install-html`:

    $ make configure
    $ ./configure --prefix=<PREFIX>

After the installation, all the html documents will copy to rootdir (/), and:

    $ git --html-path
    <PREFIX>
    $ git help -w something
    fatal: '<PREFIX>': not a documentation directory.

This is because the variable "htmldir" points to a undefined variable "$(docdir)" in file "config.mak.autogen", which is generated by running `./configure`. This bug comes from commit fc1c541 (Honor configure's htmldir switch), since v1.8.1.3-537-g1d321.

Add the required two variables "PACKAGE_TARNAME" and "docdir" to file "config.mak.in" will resolve this problem.

Signed-off-by: Jiang Xin <worldhello.net@gmail.com>
---
 config.mak.in | 2 ++
 1 file changed, 2 insertions(+)
diff --git a/config.mak.in b/config.mak.in
index d7c49..fa02bd 100644
--- a/config.mak.in
+++ b/config.mak.in
@@ -8,6 +8,7 @@ LDFLAGS = @LDFLAGS@
 AR = @AR@
 TAR = @TAR@
 DIFF = @DIFF@
+PACKAGE_TARNAME = @PACKAGE_TARNAME@
 #INSTALL = @INSTALL@		# needs install-sh or install.sh in sources
 
 prefix = @prefix@
@@ -17,6 +18,7 @@ gitexecdir = @libexecdir@/git-core
 datarootdir = @datarootdir@
 template_dir = @datadir@/git-core/templates
 sysconfdir = @sysconfdir@
+docdir = @docdir@
 
 mandir = @mandir@
 htmldir = @htmldir@
-- 
1.8.2.rc0.18.g63af42f.dirty
Next: Junio C Hamano
Message 1 of 9 in “Bugfix: undefined htmldir in config.mak.autogen”
  1. Bugfix: undefined htmldir in config.mak.autogenJiang Xin, Feb 19, 2013
  2. Junio C HamanoFeb 19, 2013
  3. Junio C HamanoFeb 19, 2013
  4. Junio C HamanoFeb 19, 2013
  5. Jiang XinFeb 20, 2013
  6. Stefano LattariniFeb 20, 2013
  7. Jiang XinFeb 20, 2013
  8. Stefano LattariniFeb 20, 2013
  9. John KeepingFeb 20, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.