[PATCH 11/18] rebase -i: Simplify commit counting for generated commit messages
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Jan 14, 2010, 05:54 UTC
- Message-ID
- <511d20b177b8ae6e978126da2af3880d2f7895e1.1263447038.git.mhagger@alum.mit.edu>
- In-Reply-To
- <cover.1263447037.git.mhagger@alum.mit.edu>
Read the old count from the first line of the old commit message rather than counting the number of commit message blocks in the file. This is simpler, faster, and more robust (e.g., it cannot be confused by strange commit message contents).
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> --- git-rebase--interactive.sh | 11 +++-------- 1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh index 16e1990..5ed80b0 100755 --- a/git-rebase--interactive.sh +++ b/git-rebase--interactive.sh @@ -351,11 +351,9 @@ nth_string () { make_squash_message () { if test -f "$SQUASH_MSG"; then - # We want to be careful about matching only the commit - # message comment lines generated by this function. - # "[snrt][tdh]" matches the nth_string endings. - COUNT=$(($(sed -n "s/^# Th[^0-9]*\([1-9][0-9]*\)[snrt][tdh] commit message.*:/\1/p" \ - < "$SQUASH_MSG" | sed -ne '$p')+1)) + COUNT=$(($(sed -n \ + -e "1s/^# This is a combination of \(.*\) commits\./\1/p" \ + -e "q" < "$SQUASH_MSG")+1)) echo "# This is a combination of $COUNT commits." sed -e 1d -e '2,/^./{ /^$/d @@ -378,9 +376,6 @@ make_squash_message () { echo echo "# The $(nth_string $COUNT) commit message will be skipped:" echo - # Comment the lines of the commit message out using - # "# " rather than "# " to make them less likely to - # confuse the sed regexp above. git cat-file commit $2 | sed -e '1,/^$/d' -e 's/^/# /' ;; esac
-- 1.6.6