Re: [PATCH 10/18] rebase -i: Improve consistency of commit count in generated commit messages
- From
Johannes Sixt <j.sixt@viscovery.net>
- Date
- Jan 14, 2010, 07:54 UTC
- Message-ID
- <4B4ECD9E.5000707@viscovery.net>
- In-Reply-To
- <1e03c6ff51ca0e6da4c19da014523f01a27b1579.1263447038.git.mhagger@alum.mit.edu>
Michael Haggerty schrieb:
> Use the numeral "2" instead of the word "two" when two commits are > being interactively squashed. This makes the treatment consistent > with that for higher numbers of commits.
Huh? This is just code churn: consistency is not an advantage here.
Oh...wait... The next patch needs it this way. Couldn't you have justified it with "In a subsequent change, we will extract the numeral and use it in an expression."
-- Hannes