Re: [feature request] git add completion should exclude staged content
- From
Manlio Perillo <manlio.perillo@gmail.com>
- Date
- Jan 28, 2013, 20:13 UTC
- Message-ID
- <5106DBE5.6040507@gmail.com>
- In-Reply-To
- <5106A5CE.3000800@drmicha.warpmail.net>
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Il 28/01/2013 17:22, Michael J Gruber ha scritto:
Show 10 quoted lines
> [...] >> The patch will suggest (for git add command), all the files that are >> candidate to be added to the index file. >> >> Please, test it and report any behaviour you think is incorrect. > > OK, that seems to work and to be quite helpful. > > Minor nit: "git add -u" could use the same fileset as "git commit". But > I don't know whether completion can act upon the presence of options.
It is possible, but I have not implemented since I was not sure about it and I wanted to avoid to make the patch more hard to review.
I will work on it after the patch is approved.
Show 6 quoted lines
> Currently, it also includes untracked files (just like without -u) but > omits unmodified and ignored ones, which is already quite an improvement. > > I won't be able to review the completion code but may contribute a few > lines to t/t9902-completion.sh, possibly. >
Ah, I missed this test; thanks.
The proposed patch must update it.
Regards Manlio -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAlEG2+UACgkQscQJ24LbaURstACfdNxuFvaokBSTls20bSQ7jPHA 8I0An3fX6oRKuc2lzAgPVBLjsbjbw91V =igwr -----END PGP SIGNATURE-----