Re: [feature request] git add completion should exclude staged content

From: Michael J Gruber <git@drmicha.warpmail.net>
Date: Jan 28, 2013, 16:22 UTC
Message-ID: <5106A5CE.3000800@drmicha.warpmail.net>
In-Reply-To: <510684FB.80104@gmail.com>

Manlio Perillo venit, vidit, dixit 28.01.2013 15:02:

Show 27 quoted lines

> Il 28/01/2013 13:52, Michael J Gruber ha scritto:
>> Manlio Perillo venit, vidit, dixit 28.01.2013 10:26:
>>> Il 28/01/2013 00:00, Junio C Hamano ha scritto:
>>>> wookietreiber <kizkizzbangbang@googlemail.com> writes:
>>>
>>>>> I have a feature request for `git add` auto completion:
>>>>>
>> [...]
>>> For the OP: the last patch can be found in the mailing list archive,
>>> with the subject:
>>> 	[PATCH v5] git-completion.bash: add support for path completion
>>> and date:
>>> 	Fri, 11 Jan 2013 19:48:43 +0100
>>>
>>> Can you please test it?
>>>
> 
>> I haven't looked at the patch, but in the example above, untracked
>> files) could be added as well (unless you use -u), so maybe the scope
>> should depend on the option? If the new completion code kept me from
>> adding untracked files easily it wouldn't be an improvement.
> 
> 
> The patch will suggest (for git add command), all the files that are
> candidate to be added to the index file.
> 
> Please, test it and report any behaviour you think is incorrect.

OK, that seems to work and to be quite helpful.

Minor nit: "git add -u" could use the same fileset as "git commit". But I don't know whether completion can act upon the presence of options. Currently, it also includes untracked files (just like without -u) but omits unmodified and ignored ones, which is already quite an improvement.

I won't be able to review the completion code but may contribute a few lines to t/t9902-completion.sh, possibly.

Michael