Re: segmentation fault (nullpointer) with git log --submodule -p
- From
Stefan Näwe <stefan.naewe@atlas-elektronik.com>
- Date
- Jan 24, 2013, 12:11 UTC
- Message-ID
- <510124F5.9090505@atlas-elektronik.com>
- In-Reply-To
- <20130123200222.GB19832@sigill.intra.peff.net>
Am 23.01.2013 21:02, schrieb Jeff King:
Show 34 quoted lines
> On Wed, Jan 23, 2013 at 03:38:16PM +0100, Armin wrote:
>
>> Hello dear git people.
>>
>> I experience a reproducible segmentation fault on one of my
>> repositories when doing a "git log --submodule -p", tested with newest
>> version on Arch Linux (git version 1.8.1.1) and built fresh (git
>> version 1.8.1.1.347.g9591fcc), tried on 2 seperate systems:
>>
>>
>> Program terminated with signal 11, Segmentation fault.
>> #0 0x00000000004b51e5 in parse_commit_header (context=0x7ffff69b6980) at pretty.c:752
>> 752 for (i = 0; msg[i]; i++) {
>> [...]
>> (gdb) l
>> 747 static void parse_commit_header(struct format_commit_context *context)
>> 748 {
>> 749 const char *msg = context->message;
>> 750 int i;
>> 751
>> 752 for (i = 0; msg[i]; i++) {
>> 753 int eol;
>> 754 for (eol = i; msg[eol] && msg[eol] != '\n'; eol++)
>> 755 ; /* do nothing */
>> 756
>> (gdb) p msg
>> $7 = <optimized out>
>> (gdb) p context->message
>> $8 = 0x0
>
> Yeah, that should definitely not be NULL. I can't reproduce here with a
> few simple examples, though.
>
> Does it fail with older versions of git? If so, can you bisect?I did. My bisection told me this is the suspect:
ccdc603 (parse_object: try internal cache before reading object db)
My git-fu is not good enough to analyze that...
> Is it possible for you to make your repo available?
Unfortunately not. It crashes with one particular repos (using submodules) that I can't make available but not with another which is available at https://github.com/snaewe/super.git
HTH
Stefan
--
----------------------------------------------------------------
/dev/random says: There must be more to life than compile-and-go.
python -c "print '73746566616e2e6e616577654061746c61732d656c656b74726f6e696b2e636f6d'.decode('hex')"