[PATCH 1/3] commit: drop useless xstrdup of commit message
- From
Jeff King <peff@peff.net>
- Date
- Jan 26, 2013, 09:42 UTC
- Message-ID
- <20130126094236.GA6999@sigill.intra.peff.net>
- In-Reply-To
- <20130126094026.GA9646@sigill.intra.peff.net>
When git-commit is asked to reuse a commit message via "-c", we call read_commit_message, which looks up the commit and hands back either the re-encoded result, or a copy of the original. We make a copy in the latter case so that the ownership semantics of the return value are clear (in either case, it can be freed).
However, since we return a "const char *", and since the resulting buffer's lifetime is the same as that of the whole program, we never bother to free it at all.
Let's just drop the copy. That saves us a copy in the common case. While it does mean we leak in the re-encode case, it doesn't matter, since we are relying on program exit to free the memory anyway.
Signed-off-by: Jeff King <peff@peff.net> --- This one isn't strictly necessary, but it makes it a lot more obvious what is going on with the memory ownership of this code in the next patch.
builtin/commit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/commit.c b/builtin/commit.c index 38b9a9c..fbbb40f 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -962,7 +962,7 @@ static const char *read_commit_message(const char *name) * encodings are identical. */ if (out == NULL) - out = xstrdup(commit->buffer); + out = commit->buffer; return out; }
-- 1.8.0.2.16.g72e2fc9