Re: [msysGit] Re: Version 1.8.1 does not compile on Cygwin 1.7.14

From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Jan 22, 2013, 18:38 UTC
Message-ID: <50FEDCB9.6090708@ramsay1.demon.co.uk>
In-Reply-To: <50FCD017.6060607@web.de>

Torsten Bögershausen wrote:

Show 24 quoted lines

> On 20.01.13 12:06, Jonathan Nieder wrote:
>> Torsten Bögershausen wrote:
>>
>>> I wonder, if if we can go one step further:
>>>
>>> Replace
>>> #ifdef WIN32 /* Both MinGW and MSVC */
>> [...]
>>> with
>>> #if defined(_MSC_VER)
>>
>> I thought Git for Windows was built using mingw, which doesn't define
>> _MSC_VER?
>>
>> Puzzled,
>> Jonathan
>>
> Yes,
> After removing these lines in the git-compat-util.h of msysgit
> v1.8.1 it still compiled.
> So I start to speculate if the comment is still valid for mingw,
> or if that was true in the old days and not now any more.
> 
> More investigation is needed, sorry for confusion.

Yes, I compiled the last patch on MinGW before I sent it to the list. I didn't bother with MSVC, since that build is already broken. I have a patch which fixed the MSVC build, but it already needs to be updated, since current master fails to build on MSVC.

ATB, Ramsay Jones