Re: Version 1.8.1 does not compile on Cygwin 1.7.14

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Jan 6, 2013, 09:57 UTC
Message-ID: <20130106095757.GC10956@elie.Belkin>
In-Reply-To: <50E946EB.1000709@web.de>

Torsten Bögershausen wrote:

> The short version:
> Cygwin versions  1.7.1 up to 1.7.16 use the same header files as cygwin 1.5

[...]

> I don't know if we want to improve the Makefile to enable 
> CYGWIN_V15_WIN32API = YesPlease 
> for cygwin versions 1.7.1 .. 1.7.16 (which are outdated)

Confusing. Sounds like the condition in 380a4d92 (Update cygwin.c for new mingw-64 win32 api headers, 2012-11-11) was too strict and the Makefile should say something like

	# Cygwin versions up to 1.7.16 used the same headers
	# as Cygwin 1.5.
	ifeq ($(shell expr "$(uname_R)" : '1\.7\.[0-9]$$'),5)
		CYGWIN_V15_WIN32API = YesPlease
	endif
	ifeq ($(shell expr "$(uname_R)" : '1\.7\.1[0-6]$$'),6)
		CYGWIN_V15_WIN32API = YesPlease
	endif

	ifeq ($(shell expr "$(uname_R)" : '1\.[1-6]\.'),4)
		CYGWIN_V15_WIN32API = YesPlease
		...
	endif

Is that right?