git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix t9200 on case insensitive file systems

From
Torsten Bögershausen <tboegi@web.de>
Date
Oct 28, 2012, 15:28 UTC
Message-ID
<508D4F13.1090209@web.de>
In-Reply-To
<20121028111053.GC11434@sigill.intra.peff.net>
On 28.10.12 12:10, Jeff King wrote:
Show 34 quoted lines
> On Fri, Oct 26, 2012 at 06:18:24PM +0200, Torsten Bögershausen wrote:
> 
>> t9200 defines $CVSROOT where cvs should init its repository
>> $CVSROOT is set to $PWD/cvsroot.
>> cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT
>>
>> "cvs init" (e.g. version  1.11.23) checks if the last element of the path is
>> "CVSROOT", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists.
>>
>> For such a $CVSROOT cvs refuses to init a repository here:
>> "Cannot initialize repository under existing CVSROOT:
>>
>> On a case insenstive file system cvsroot and CVSROOT are the same directories
>> and t9200 fails.
>>
>> Solution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot
> 
> Wouldn't tmp/cvsroot have the same problem, since the basename is still
> cvsroot?
> 
>> diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
>> index b59be9a..69934b2 100755
>> --- a/t/t9200-git-cvsexportcommit.sh
>> +++ b/t/t9200-git-cvsexportcommit.sh
>> @@ -19,7 +19,7 @@ then
>>      test_done
>>  fi
>>  
>> -CVSROOT=$PWD/cvsroot
>> +CVSROOT=$PWD/tmpcvsroot
> 
> Ah, but here you do something different, which makes sense. Should I
> tweak the commit message?
> 
Yes, please do so.

Thanks for spotting, /torsten

Previous: Jeff King
Message 4 of 4 in “Fix t9200 on case insensitive file systems”
  1. Fix t9200 on case insensitive file systemsTorsten Bögershausen, Oct 26, 2012
  2. Ben WaltonOct 27, 2012
  3. Jeff KingOct 28, 2012
  4. Torsten BögershausenOct 28, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.