From: Torsten Bögershausen <tboegi@web.de>
Date: Sun, 28 Oct 2012 15:28:19 GMT
Subject: Re: [PATCH] Fix t9200 on case insensitive file systems
Message-ID: <508D4F13.1090209@web.de>
In-Reply-To: <20121028111053.GC11434@sigill.intra.peff.net>

On 28.10.12 12:10, Jeff King wrote:
> On Fri, Oct 26, 2012 at 06:18:24PM +0200, Torsten Bögershausen wrote:
> 
>> t9200 defines $CVSROOT where cvs should init its repository
>> $CVSROOT is set to $PWD/cvsroot.
>> cvs init is supposed to create the repository inside $PWD/cvsroot/CVSROOT
>>
>> "cvs init" (e.g. version  1.11.23) checks if the last element of the path is
>> "CVSROOT", and if a directory with e.g. $PWD/cvsroot/CVSROOT already exists.
>>
>> For such a $CVSROOT cvs refuses to init a repository here:
>> "Cannot initialize repository under existing CVSROOT:
>>
>> On a case insenstive file system cvsroot and CVSROOT are the same directories
>> and t9200 fails.
>>
>> Solution: use $PWD/tmp/cvsroot instead of cvsroot $PWD/cvsroot
> 
> Wouldn't tmp/cvsroot have the same problem, since the basename is still
> cvsroot?
> 
>> diff --git a/t/t9200-git-cvsexportcommit.sh b/t/t9200-git-cvsexportcommit.sh
>> index b59be9a..69934b2 100755
>> --- a/t/t9200-git-cvsexportcommit.sh
>> +++ b/t/t9200-git-cvsexportcommit.sh
>> @@ -19,7 +19,7 @@ then
>>      test_done
>>  fi
>>  
>> -CVSROOT=$PWD/cvsroot
>> +CVSROOT=$PWD/tmpcvsroot
> 
> Ah, but here you do something different, which makes sense. Should I
> tweak the commit message?
> 

Yes, please do so.

Thanks for spotting,
/torsten