Re: [PATCH] git-gui: Few issues with using full path name
- From
Andrew Wong <andrew.kw.w@gmail.com>
- Date
- Oct 12, 2012, 14:08 UTC
- Message-ID
- <50782442.2060407@gmail.com>
- In-Reply-To
- <1349195115-15494-1-git-send-email-andrew.kw.w@gmail.com>
Can I get some feedback on these two patches? It'd be great to have them merged into git-gui. Thanks.
On 10/02/2012 12:25 PM, Andrew Wong wrote:
Show 20 quoted lines
> I ran into a file name parsing issue in git-gui. If I'm in a subfolder and try > to pass a full path to "git-gui blame", then "git-gui" will fail to detect the > argument as a valid path. The first patch will handle this scenario. > > The second patch just another issue that I noticed when "git-gui" fails to > detect the file name. It'll then try to use the previously detected "head" as > the file name, while prepending it with "prefix". This is incorrect if "head" > is actually a full path. > > There is also an issue when using a full path along with a rev argument, but I > don't have time to look it right now. I'll try to get to that issue another > time. > > Andrew Wong (2): > git-gui: Detect full path when parsing arguments > git-gui: Don't prepend the prefix if value looks like a full path > > git-gui.sh | 20 +++++++++++++++++--- > 1 file changed, 17 insertions(+), 3 deletions(-) >