git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] git-gui: Few issues with using full path name

From
Andrew Wong <andrew.kw.w@gmail.com>
Date
Oct 2, 2012, 16:25 UTC
Message-ID
<1349195115-15494-1-git-send-email-andrew.kw.w@gmail.com>

I ran into a file name parsing issue in git-gui. If I'm in a subfolder and try to pass a full path to "git-gui blame", then "git-gui" will fail to detect the argument as a valid path. The first patch will handle this scenario.

The second patch just another issue that I noticed when "git-gui" fails to detect the file name. It'll then try to use the previously detected "head" as the file name, while prepending it with "prefix". This is incorrect if "head" is actually a full path.

There is also an issue when using a full path along with a rev argument, but I don't have time to look it right now. I'll try to get to that issue another time.

Andrew Wong (2):
  git-gui: Detect full path when parsing arguments
  git-gui: Don't prepend the prefix if value looks like a full path
 git-gui.sh | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)
-- 
1.7.12.1.382.gb0576a6
Next: Andrew Wong
Message 1 of 5 in “git-gui: Few issues with using full path name”
  1. git-gui: Few issues with using full path nameAndrew Wong, Oct 2, 2012
  2. 1/2 git-gui: Detect full path when parsing argumentsAndrew Wong, Oct 2, 2012
  3. 2/2 git-gui: Don't prepend the prefix if value looks like a full pathAndrew Wong, Oct 2, 2012
  4. Andrew WongOct 7, 2012
  5. Andrew WongOct 12, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.