git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Remove the hard coded length limit on variable names in config files

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Oct 1, 2012, 03:16 UTC
Message-ID
<50690B28.5030408@alum.mit.edu>
In-Reply-To
<CAP30j15wKa7wbLyaLo8omHcAh5u7O=Yt8Tjy4bD3V_0nT1zJPQ@mail.gmail.com>
On 09/30/2012 08:20 PM, Ben Walton wrote:
Show 6 quoted lines
>> The patch doesn't apply to the current master; it appears to have been
>> built against master 883a2a3504 (2012-02-23) or older.  It will have to
>> be rebased to the current master.
> 
> Junio had asked that it be based on maint so that's what I (thought
> I?) did.  I'm happy to redo it against master if that's better though.

That explains it. Sorry, I hadn't seen that conversation. (In the future, if a patch applies against something other than master, please add a note in the cover letter or in the patch comment after the "--".)

It is OK with me to leave the patch against maint, if that is what Junio wanted. It would help, though, if you rebase it to the latest maint (the conflict seems easy to fix).

Thanks, Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Junio C Hamano
Message 9 of 9 in “Prevent git-config from storing section keys that are too long”
  1. Prevent git-config from storing section keys that are too longBen Walton, Sep 7, 2012
  2. Junio C HamanoSep 7, 2012
  3. Ben WaltonSep 7, 2012
  4. Remove the hard coded length limit on variable names in config filesBen Walton, Sep 29, 2012
  5. Michael HaggertySep 30, 2012
  6. Ben WaltonSep 30, 2012
  7. Remove the hard coded length limit on variable names in config filesBen Walton, Sep 30, 2012
  8. Junio C HamanoOct 1, 2012
  9. Michael HaggertyOct 1, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.