git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-string-list.c: Fix some sparse warnings

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Sep 17, 2012, 08:15 UTC
Message-ID
<5056DC28.60809@alum.mit.edu>
In-Reply-To
<5054AA62.2040603@ramsay1.demon.co.uk>
On 09/15/2012 06:18 PM, Ramsay Jones wrote:
Show 16 quoted lines
> 
> In particular, sparse complains as follows:
> 
>         SP test-string-list.c
>     test-string-list.c:10:6: warning: symbol 'parse_string_list' was not \
>         declared. Should it be static?
>     test-string-list.c:18:6: warning: symbol 'write_list' was not \
>         declared. Should it be static?
>     test-string-list.c:25:6: warning: symbol 'write_list_compact' was not \
>         declared. Should it be static?
>     test-string-list.c:38:5: warning: symbol 'prefix_cb' was not \
>         declared. Should it be static?
> 
> In order to suppress the warnings, since the above symbols do not
> need more than file scope, we simply include the static modifier
> in their declaration.
Thanks for fixing this.
Is there some documentation about how to run sparse on the git codebase?
 I naively tried "make sparse" and ended up with zillions of errors like

/usr/include/unistd.h:288:54: error: attribute '__leaf__': unknown attribute /usr/include/unistd.h:294:6: error: attribute '__leaf__': unknown attribute /usr/include/unistd.h:298:6: error: attribute '__leaf__': unknown attribute /usr/include/unistd.h:306:6: error: attribute '__leaf__': unknown attribute /usr/include/unistd.h:338:18: error: attribute '__leaf__': unknown attribute /usr/include/unistd.h:347:6: error: attribute '__leaf__': unknown attribute /usr/include/unistd.h:418:36: error: attribute '__leaf__': unknown attribute /usr/include/unistd.h:423:50: error: attribute '__leaf__': unknown attribute

Michael
-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
Previous: Junio C HamanoNext: Ramsay Jones
Message 13 of 15 in “test-string-list.c: Fix some sparse warnings”
  1. test-string-list.c: Fix some sparse warningsRamsay Jones, Sep 15, 2012
  2. Junio C HamanoSep 15, 2012
  3. 1/7 builtin/notes.c: mark file-scope functions as staticJunio C Hamano, Sep 15, 2012
  4. 2/7 commit.c: mark file-scope functions as staticJunio C Hamano, Sep 15, 2012
  5. 3/7 diff.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  6. 4/7 graph.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  7. 5/7 grep.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  8. Ramsay JonesSep 19, 2012
  9. Junio C HamanoSep 19, 2012
  10. Ramsay JonesSep 20, 2012
  11. 6/7 rerere.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  12. 7/7 notes.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  13. Michael HaggertySep 17, 2012
  14. Ramsay JonesSep 19, 2012
  15. Michael HaggertySep 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.