git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 7/7] notes.c: mark private file-scope symbols as static

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 15, 2012, 21:10 UTC
Message-ID
<1347743452-2487-7-git-send-email-gitster@pobox.com>
In-Reply-To
<1347743452-2487-1-git-send-email-gitster@pobox.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 notes.c | 14 ++++++++++++--
 notes.h | 14 --------------
 2 files changed, 12 insertions(+), 16 deletions(-)
diff --git a/notes.c b/notes.c
index 93e9868..bc454e1 100644
--- a/notes.c
+++ b/notes.c
@@ -1196,8 +1196,18 @@ void free_notes(struct notes_tree *t)
 	memset(t, 0, sizeof(struct notes_tree));
 }
 
-void format_note(struct notes_tree *t, const unsigned char *object_sha1,
-		struct strbuf *sb, const char *output_encoding, int flags)
+/*
+ * Fill the given strbuf with the notes associated with the given object.
+ *
+ * If the given notes_tree structure is not initialized, it will be auto-
+ * initialized to the default value (see documentation for init_notes() above).
+ * If the given notes_tree is NULL, the internal/default notes_tree will be
+ * used instead.
+ *
+ * 'flags' is a bitwise combination of the flags for format_display_notes.
+ */
+static void format_note(struct notes_tree *t, const unsigned char *object_sha1,
+			struct strbuf *sb, const char *output_encoding, int flags)
 {
 	static const char utf8[] = "utf-8";
 	const unsigned char *sha1;
diff --git a/notes.h b/notes.h
index c716694..3592b19 100644
--- a/notes.h
+++ b/notes.h
@@ -241,20 +241,6 @@ void free_notes(struct notes_tree *t);
 #define NOTES_SHOW_HEADER 1
 #define NOTES_INDENT 2
 
-/*
- * Fill the given strbuf with the notes associated with the given object.
- *
- * If the given notes_tree structure is not initialized, it will be auto-
- * initialized to the default value (see documentation for init_notes() above).
- * If the given notes_tree is NULL, the internal/default notes_tree will be
- * used instead.
- *
- * 'flags' is a bitwise combination of the above formatting flags.
- */
-void format_note(struct notes_tree *t, const unsigned char *object_sha1,
-		struct strbuf *sb, const char *output_encoding, int flags);
-
-
 struct string_list;
 
 struct display_notes_opt {
-- 
1.7.12.508.g4d78187
Previous: Junio C HamanoNext: Michael Haggerty
Message 12 of 15 in “test-string-list.c: Fix some sparse warnings”
  1. test-string-list.c: Fix some sparse warningsRamsay Jones, Sep 15, 2012
  2. Junio C HamanoSep 15, 2012
  3. 1/7 builtin/notes.c: mark file-scope functions as staticJunio C Hamano, Sep 15, 2012
  4. 2/7 commit.c: mark file-scope functions as staticJunio C Hamano, Sep 15, 2012
  5. 3/7 diff.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  6. 4/7 graph.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  7. 5/7 grep.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  8. Ramsay JonesSep 19, 2012
  9. Junio C HamanoSep 19, 2012
  10. Ramsay JonesSep 20, 2012
  11. 6/7 rerere.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  12. 7/7 notes.c: mark private file-scope symbols as staticJunio C Hamano, Sep 15, 2012
  13. Michael HaggertySep 17, 2012
  14. Ramsay JonesSep 19, 2012
  15. Michael HaggertySep 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.