Re: [PATCHv2 01/12] git p4 test: remove bash-ism of combined export/assignment

From: Luke Diamand <luke@diamand.org>
Date: Sep 15, 2012, 21:25 UTC
Message-ID: <5054F22D.2020909@diamand.org>
In-Reply-To: <1347221773-12773-2-git-send-email-pw@padd.com>

Looks good to me, ack.

On 09/09/12 21:16, Pete Wyckoff wrote:

Show 23 quoted lines

> Signed-off-by: Pete Wyckoff<pw@padd.com>
> ---
>   t/lib-git-p4.sh | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/t/lib-git-p4.sh b/t/lib-git-p4.sh
> index 2d753ab..482eeac 100644
> --- a/t/lib-git-p4.sh
> +++ b/t/lib-git-p4.sh
> @@ -26,9 +26,10 @@ testid=${this_test#t}
>   git_p4_test_start=9800
>   P4DPORT=$((10669 + ($testid - $git_p4_test_start)))
>
> -export P4PORT=localhost:$P4DPORT
> -export P4CLIENT=client
> -export P4EDITOR=:
> +P4PORT=localhost:$P4DPORT
> +P4CLIENT=client
> +P4EDITOR=:
> +export P4PORT P4CLIENT P4EDITOR
>
>   db="$TRASH_DIRECTORY/db"
>   cli=$(test-path-utils real_path "$TRASH_DIRECTORY/cli")