git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCHv2 00/12] git p4: submit conflict handling

From
PWPete Wyckoff <pw@padd.com>
Date
Sep 9, 2012, 20:16 UTC
Message-ID
<1347221773-12773-1-git-send-email-pw@padd.com>
Changes from v1, due to review from Luke and Hannes:
    * Drop the patch to suppress of p4d log messages, it is
      sometimes useful to watch.
    * Fix extra line before shebang in t9815.  (Thanks Hannes.)
    * Use "skip", not "continue" in the prompt about what to
      do next, just like before this series.
    * Automate the interactive prompt when a submit conflict
      is detected, with "git p4 submit --conflict=skip" or
      config variable git-p4.conflict.
    This does not try to fix the rebase path.  It adds the
    auto-skip during the submit phase, but changes are needed
    in rebase to understand that skips happened.  One approach
    is to skip the rebase, and just reset HEAD.
    Luke:  You have a patch for git-p4.skipConflictingChanges
    that I think might work with --conflict=skip or git-p4.skip.
    With this series, logging already happens in submit, so you
    might just quietly say "git rebase --skip".  Let me know
    if you think this is a good approach, so that this series
    can go in, and you can handle the rebase part.
    Version 1 of this series:
	http://thread.gmane.org/gmane.comp.version-control.git/203570
    Blurb (edited) from v1 follows.

These patches rework how git p4 deals with conflicts that arise during a "git p4 submit". These may arise due to changes that happened in p4 since the last "git p4 sync".

The part that needs the most attention is the interaction loop that happens when a commit failed. Currently, three options are offered:

    [s]kip this commit, but continue to apply others
    [a]pply the commit forcefully, generating .rej files
    [w]rite the commit to a patch.txt file
    and the implicit <ctrl-c> to stop
After this series, it offers two:
    [s]kip this commit but apply the rest
    [q]uit to stop
Other observable changes are new command-line options:
Alias -v for --verbose, similar to other git commands.
The --dry-run option addresses Luke's concern in
    http://thread.gmane.org/gmane.comp.version-control.git/201004/focus=201022

when I removed an unused "self.interactive" variable that did a similar thing if you edited the code. It prints commits that would be applied to p4.

Option --prepare-p4-only is similar to --dry-run, in that it does not submit anything to p4, but it does prepare the p4 workspace, then prints long instructions about how to submit everything properly. It also serves, perhaps, as a replacement for the [a]pply option in the submit-conflict loop.

Option --conflict=skip (new in v2) automates the prompt handling when conflicts happen.

Pete Wyckoff (12):
  git p4 test: remove bash-ism of combined export/assignment
  git p4: gracefully fail if some commits could not be applied
  git p4: remove submit failure options [a]pply and [w]rite
  git p4: move conflict prompt into run, add [q]uit input
  git p4: standardize submit cancel due to unchanged template
  git p4: test clean-up after failed submit, fix added files
  git p4: rearrange submit template construction
  git p4: revert deleted files after submit cancel
  git p4: accept -v for --verbose
  git p4: add submit --dry-run option
  git p4: add submit --prepare-p4-only option
  git-p4: add submit --conflict option and config varaiable
 Documentation/git-p4.txt           |  24 ++-
 git-p4.py                          | 239 ++++++++++++++++-----
 t/lib-git-p4.sh                    |   7 +-
 t/t9805-git-p4-skip-submit-edit.sh |   2 +-
 t/t9807-git-p4-submit.sh           |  65 ++++++
 t/t9810-git-p4-rcs.sh              |  50 +----
 t/t9815-git-p4-submit-fail.sh      | 429 +++++++++++++++++++++++++++++++++++++
 7 files changed, 709 insertions(+), 107 deletions(-)
 create mode 100755 t/t9815-git-p4-submit-fail.sh
-- 
1.7.12.rc2.111.g96f7c73
Next: Pete Wyckoff
Message 1 of 22 in “[PATCHv2 00/12] git p4: submit conflict handling”
  1. Pete WyckoffSep 9, 2012
  2. 01/12 git p4 test: remove bash-ism of combined export/assignmentPete Wyckoff, Sep 9, 2012
  3. Luke DiamandSep 15, 2012
  4. Junio C HamanoSep 16, 2012
  5. Luke DiamandSep 16, 2012
  6. Junio C HamanoSep 17, 2012
  7. Luke DiamandSep 17, 2012
  8. 02/12 git p4: gracefully fail if some commits could not be appliedPete Wyckoff, Sep 9, 2012
  9. Luke DiamandSep 15, 2012
  10. 03/12 git p4: remove submit failure options [a]pply and [w]ritePete Wyckoff, Sep 9, 2012
  11. Luke DiamandSep 15, 2012
  12. 04/12 git p4: move conflict prompt into run, add [q]uit inputPete Wyckoff, Sep 9, 2012
  13. Luke DiamandSep 15, 2012
  14. 05/12 git p4: standardize submit cancel due to unchanged templatePete Wyckoff, Sep 9, 2012
  15. Luke DiamandSep 15, 2012
  16. 06/12 git p4: test clean-up after failed submit, fix added filesPete Wyckoff, Sep 9, 2012
  17. 07/12 git p4: rearrange submit template constructionPete Wyckoff, Sep 9, 2012
  18. 08/12 git p4: revert deleted files after submit cancelPete Wyckoff, Sep 9, 2012
  19. 09/12 git p4: accept -v for --verbosePete Wyckoff, Sep 9, 2012
  20. 10/12 git p4: add submit --dry-run optionPete Wyckoff, Sep 9, 2012
  21. 11/12 git p4: add submit --prepare-p4-only optionPete Wyckoff, Sep 9, 2012
  22. 12/12 git-p4: add submit --conflict option and config varaiablePete Wyckoff, Sep 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.