git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 9/8] t0060: split absolute path test in two to exercise some of it on Windows

From
Johannes Sixt <j6t@kdbg.org>
Date
Sep 9, 2012, 15:42 UTC
Message-ID
<504CB8DC.90202@kdbg.org>
In-Reply-To
<1346971264-23744-1-git-send-email-mhagger@alum.mit.edu>

Only the first half of the test works only on POSIX, the second half passes on Windows as well.

A later test "real path removes other extra slashes" looks very similar, but it does not make sense to split it in the same way: When two slashes are prepended in front of an absolute DOS-style path on Windows, the meaning of the path is changed (//server/share style), so that the test cannot pass on Windows.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 The series passes for me as is, but one test needs POSIX only in
 the first half. This patch splits it in two.
 t/t0060-path-utils.sh | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh
index e40f764..4ef2345 100755
--- a/t/t0060-path-utils.sh
+++ b/t/t0060-path-utils.sh
@@ -148,10 +148,14 @@ test_expect_success 'real path rejects the empty string' '
 	test_must_fail test-path-utils real_path ""
 '
 
-test_expect_success POSIX 'real path works on absolute paths' '
+test_expect_success POSIX 'real path works on absolute paths 1' '
 	nopath="hopefully-absent-path" &&
 	test "/" = "$(test-path-utils real_path "/")" &&
-	test "/$nopath" = "$(test-path-utils real_path "/$nopath")" &&
+	test "/$nopath" = "$(test-path-utils real_path "/$nopath")"
+'
+
+test_expect_success 'real path works on absolute paths 2' '
+	nopath="hopefully-absent-path" &&
 	# Find an existing top-level directory for the remaining tests:
 	d=$(pwd -P | sed -e "s|^\([^/]*/[^/]*\)/.*|\1|") &&
 	test "$d" = "$(test-path-utils real_path "$d")" &&
-- 
1.7.12.1493.g247bc0e
Previous: Michael HaggertyNext: Michael Haggerty
Message 13 of 14 in “Fix some bugs in abspath.c”
  1. 0/8 Fix some bugs in abspath.cMichael Haggerty, Sep 6, 2012
  2. 1/8 t0060: move tests of real_path() from t0000 to hereMichael Haggerty, Sep 6, 2012
  3. 2/8 t0060: verify that absolute_path() fails if passed the empty stringMichael Haggerty, Sep 6, 2012
  4. 3/8 absolute_path(): reject the empty stringMichael Haggerty, Sep 6, 2012
  5. Junio C HamanoSep 6, 2012
  6. Michael HaggertySep 9, 2012
  7. Junio C HamanoSep 9, 2012
  8. 4/8 t0060: verify that real_path() fails if passed the empty stringMichael Haggerty, Sep 6, 2012
  9. 5/8 real_path(): reject the empty stringMichael Haggerty, Sep 6, 2012
  10. 6/8 t0060: verify that real_path() works correctly with absolute pathsMichael Haggerty, Sep 6, 2012
  11. 7/8 real_path(): properly handle nonexistent top-level pathsMichael Haggerty, Sep 6, 2012
  12. 8/8 t0060: verify that real_path() removes extra slashesMichael Haggerty, Sep 6, 2012
  13. 9/8 t0060: split absolute path test in two to exercise some of it on WindowsJohannes Sixt, Sep 9, 2012
  14. Michael HaggertySep 10, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.