[PATCH v2 5/8] real_path(): reject the empty string
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
---
abspath.c | 3 +++
t/t0060-path-utils.sh | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/abspath.c b/abspath.c
index 5d62430..3e8325c 100644
--- a/abspath.c
+++ b/abspath.c
@@ -35,6 +35,9 @@ const char *real_path(const char *path)
if (path == buf || path == next_buf)
return path;
+ if (!*path)
+ die("The empty string is not a valid path");
+
if (strlcpy(buf, path, PATH_MAX) >= PATH_MAX)
die ("Too long path: %.*s", 60, path);
diff --git a/t/t0060-path-utils.sh b/t/t0060-path-utils.sh
index 1118056..fab5ea2 100755
--- a/t/t0060-path-utils.sh
+++ b/t/t0060-path-utils.sh
@@ -144,7 +144,7 @@ test_expect_success 'absolute path rejects the empty string' '
test_must_fail test-path-utils absolute_path ""
'
-test_expect_failure 'real path rejects the empty string' '
+test_expect_success 'real path rejects the empty string' '
test_must_fail test-path-utils real_path ""
'
--
1.7.11.3
Michael Haggerty <mhagger@alum.mit.edu>