git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t5150: skip request-pull test if Perl is disabled

From
Ruud van Asseldonk <dev@veniogames.com>
Date
Nov 26, 2019, 00:02 UTC
Message-ID
<4f11b5b3-a68e-642a-c5fb-7b5dae698669@veniogames.com>

The git-request-pull.sh script invokes Perl, so it requires Perl to be available, but the associated test t5150 does not skip itself when Perl has been disabled, which then makes subtest 4 through 10 fail. Subtest 3 still passes, but for the wrong reasons (it expects git-request-pull to fail, and it does fail when Perl is not available). The initial two subtests that do pass are only doing setup.

To prevent t5150 from failing the build when NO_PERL=1, add a check that sets skip_all when "! test_have_prereq PERL", just like how for example t3701-add-interactive skips itself when Perl has been disabled.

Signed-off-by: Ruud van Asseldonk <dev@veniogames.com>
---
I discovered this issue in the Git package in Nixpkgs. The Nix package
manager tries to make it hard to accidentally introduce undeclared
dependencies, and it has a sandbox that hides things in /usr/bin. So
when it builds with NO_PERL=1, it really makes no Perl available, so you
cannot accidentally depend on the Perl in /usr/bin/perl. For the tests
it does set PERL_PATH, but it does not point to a binary in /usr/bin.
 t/t5150-request-pull.sh | 6 ++++++
 1 file changed, 6 insertions(+)
diff --git a/t/t5150-request-pull.sh b/t/t5150-request-pull.sh
index 852dcd913f..1ad4ecc29a 100755
--- a/t/t5150-request-pull.sh
+++ b/t/t5150-request-pull.sh
@@ -4,6 +4,12 @@ test_description='Test workflows involving pull request.'
 
 . ./test-lib.sh
 
+if ! test_have_prereq PERL
+then
+	skip_all='skipping request-pull tests, perl not available'
+	test_done
+fi
+
 test_expect_success 'setup' '
 
 	git init --bare upstream.git &&
-- 
2.24.0
Next: Jonathan Nieder
Message 1 of 11 in “t5150: skip request-pull test if Perl is disabled”
  1. t5150: skip request-pull test if Perl is disabledRuud van Asseldonk, Nov 26, 2019
  2. Jonathan NiederNov 26, 2019
  3. Jonathan NiederNov 26, 2019
  4. Ruud van AsseldonkNov 27, 2019
  5. Jeff KingNov 27, 2019
  6. Ruud van AsseldonkNov 27, 2019
  7. Jonathan NiederNov 28, 2019
  8. Jonathan NiederNov 28, 2019
  9. Junio C HamanoDec 2, 2019
  10. Jeff KingDec 13, 2019
  11. Junio C HamanoDec 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.