git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t5150: skip request-pull test if Perl is disabled

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Nov 28, 2019, 01:35 UTC
Message-ID
<20191128013501.GB76989@google.com>
In-Reply-To
<55d0bcd1-1f15-46ff-42f1-be87eedc2e11@veniogames.com>
Hi,
Ruud van Asseldonk wrote:
> Jeff King wrote:
Show 5 quoted lines
>> I think NO_PERL has historically mostly meant "do not build or install
>> perl scripts", and not "everything ought to run fine without perl".
>> We've generally assumed you can run vanilla perl snippets from the
>> command line the same way you'd run awk or sed (and the tests use this
>> extensively, which is why you have to set PERL_PATH again to run them)

We've definitely held the stance that NO_PERL doesn't mean to disable perl in tests. For casual use of perl in installed shell scripts, on the other hand, I suspect it was more that we forgot about them than that we had decided one way or another. :)

[...]
Show 14 quoted lines
>> That said, most of those casual uses of perl in actual built scripts
>> have gone away because the shell scripts have gone away. It looks like
>> filter-branch, request-pull, and instaweb are the last holdouts. So
>> maybe we should be treating NO_PERL as disabling those scripts, too.
>>
>> But then, should we be doing more to make it clear that those scripts
>> are broken in a NO_PERL build? Who knows what happens if you run
>> filter-branch without any perl available?
>
> My understanding was that NO_PERL controlled the runtime dependencies of
> Git, and that the tests require Perl either way. Of course, without Perl any
> scripts that depend on it can't be used, but like you say, there are few of
> them left. I think it would make sense to not install those scripts when
> NO_PERL=1. Should I make a patch to change that in the makefile?

Yes, that sounds good to me. (The status quo also seems fine to me, but I like that this proposed approach would simplify things a little.)

Thanks for working on this, and sorry for the earlier noise.

Sincerely, Jonathan

Previous: Ruud van AsseldonkNext: Jonathan Nieder
Message 7 of 11 in “t5150: skip request-pull test if Perl is disabled”
  1. t5150: skip request-pull test if Perl is disabledRuud van Asseldonk, Nov 26, 2019
  2. Jonathan NiederNov 26, 2019
  3. Jonathan NiederNov 26, 2019
  4. Ruud van AsseldonkNov 27, 2019
  5. Jeff KingNov 27, 2019
  6. Ruud van AsseldonkNov 27, 2019
  7. Jonathan NiederNov 28, 2019
  8. Jonathan NiederNov 28, 2019
  9. Junio C HamanoDec 2, 2019
  10. Jeff KingDec 13, 2019
  11. Junio C HamanoDec 16, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.