[PATCH 2/4] compat: use git_mkdtemp()
- From
René Scharfe <l.s.r@web.de>
- Date
- Dec 3, 2025, 10:52 UTC
- Message-ID
- <4c70b527-9c40-4396-8c8c-95177c5d92f0@web.de>
- In-Reply-To
- <784f495a-4b1a-4acf-96cd-599243ef9e27@web.de>
A file might appear at the path returned by mktemp(3) before we call mkdir(2). Use the more robust git_mkdtemp() instead, which retries a number of times and doesn't need to call lstat(2).
Signed-off-by: René Scharfe <l.s.r@web.de> --- compat/mkdtemp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/compat/mkdtemp.c b/compat/mkdtemp.c index 1136119592..fcdd4e01e1 100644 --- a/compat/mkdtemp.c +++ b/compat/mkdtemp.c @@ -2,7 +2,5 @@ char *gitmkdtemp(char *template) { - if (!*mktemp(template) || mkdir(template, 0700)) - return NULL; - return template; + return git_mkdtemp(template); }
-- 2.52.0