git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/5] ban mktemp(3)

From
Jeff King <peff@peff.net>
Date
Dec 8, 2025, 20:33 UTC
Message-ID
<20251208203307.GD216526@coredump.intra.peff.net>
In-Reply-To
<64e62623-b911-4ddd-a481-05191853c0a6@web.de>
On Sat, Dec 06, 2025 at 02:21:06PM +0100, René Scharfe wrote:
Show 6 quoted lines
> mktemp(3) is insecure and POSIX.1-2008 no longer specifies it.  Stop
> using it.
> 
> Changes since v1:
> - add comment regarding return values of git_mkdstemps_mode()
> - add patch to drop trivialized gitmkdtemp()

Thanks, this all looks reasonable to me. I don't have a system without mkdtemp() to test the meson change on, but I can confirm it builds on Linux for me using meson. ;)

-Peff
Previous: René Scharfe
Message 19 of 19 in “ban mktemp(3)”
  1. 0/4 ban mktemp(3)René Scharfe, Dec 3, 2025
  2. 1/4 wrapper: add git_mkdtemp()René Scharfe, Dec 3, 2025
  3. Chris TorekDec 4, 2025
  4. Junio C HamanoDec 5, 2025
  5. 2/4 compat: use git_mkdtemp()René Scharfe, Dec 3, 2025
  6. Jeff KingDec 3, 2025
  7. René ScharfeDec 5, 2025
  8. Jeff KingDec 6, 2025
  9. Junio C HamanoDec 5, 2025
  10. 3/4 compat: remove mingw_mktemp()René Scharfe, Dec 3, 2025
  11. 4/4 banned.h: ban mktemp(3)René Scharfe, Dec 3, 2025
  12. Jeff KingDec 3, 2025
  13. 0/5 ban mktemp(3)René Scharfe, Dec 6, 2025
  14. 1/5 wrapper: add git_mkdtemp()René Scharfe, Dec 6, 2025
  15. 2/5 compat: use git_mkdtemp()René Scharfe, Dec 6, 2025
  16. 3/5 compat: remove mingw_mktemp()René Scharfe, Dec 6, 2025
  17. 4/5 banned.h: ban mktemp(3)René Scharfe, Dec 6, 2025
  18. 5/5 compat: remove gitmkdtemp()René Scharfe, Dec 6, 2025
  19. Jeff KingDec 8, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.