git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] builtin/add: add a missing newline to an stderr message

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Aug 8, 2017, 21:36 UTC
Message-ID
<4b0d092f-5a1b-73c7-38fe-48455099bcff@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Junio,

I noticed this while looking into the t3700 failure on cygwin tonight. Also, I couldn't decide whether or not to add the i18n '_()' brackets around the message. In the end I didn't, but will happily add them if you think I should.

Thanks!

ATB, Ramsay Jones

 builtin/add.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/add.c b/builtin/add.c
index e888fb8c5..385b53ae7 100644
--- a/builtin/add.c
+++ b/builtin/add.c
@@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int force_mode)
 			continue;
 
 		if (chmod_cache_entry(ce, force_mode) < 0)
-			fprintf(stderr, "cannot chmod '%s'", ce->name);
+			fprintf(stderr, "cannot chmod '%s'\n", ce->name);
 	}
 }
 
-- 
2.14.0
Next: René Scharfe
Message 1 of 7 in “builtin/add: add a missing newline to an stderr message”
  1. builtin/add: add a missing newline to an stderr messageRamsay Jones, Aug 8, 2017
  2. René ScharfeAug 8, 2017
  3. Junio C HamanoAug 8, 2017
  4. Jonathan NiederAug 8, 2017
  5. Junio C HamanoAug 9, 2017
  6. Ramsay JonesAug 8, 2017
  7. Jonathan NiederAug 8, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.